NavigationAgent3D: fix for avoidance stored_y_velocity #108277
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`stored_y_velocity` was being reset when the navigation agent finished navigating. Also, it wasn't being stored when navigation was not ongoing. As a result, gravity could not be applied to navigation agents with avoidance enabled. In this commit, I made two changes. Only reset `stored_y_velocity` in `NavigationAgent3D::_transition_to_navigation_finished()` if `use_3d_avoidance` is set. And save off the y velocity in `NavigationAgent3D::set_velocity()`. fixes godotengine#108252
AThousandShips
added
bug
topic:navigation
topic:3d
cherrypick:4.4
Repiteo
added
the
cherrypick:4.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stored_y_velocitywas being reset when the navigation agent finished navigating. Also, it wasn't being stored when navigation was not ongoing. As a result, gravity could not be applied to navigation agents with avoidance enabled.In this commit, I made two changes. Only reset
stored_y_velocityinNavigationAgent3D::_transition_to_navigation_finished()ifuse_3d_avoidanceis set. And save off the y velocity inNavigationAgent3D::set_velocity().fixes #108252