Fix inheriting from abstract classes dialog #109203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
cherrypick:4.4
KoBeWi
reviewed
Aug 4, 2025
IphStich
force-pushed
the
fix_dialog_inherits_abstract
branch
from
a862cd0 to
995a3a6
Compare
KoBeWi
reviewed
Aug 5, 2025
KoBeWi
reviewed
Aug 5, 2025
KoBeWi
approved these changes
Aug 5, 2025
IphStich
force-pushed
the
fix_dialog_inherits_abstract
branch
from
995a3a6 to
8835ac2
Compare
KoBeWi
approved these changes
Aug 7, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108242
Script classes marked as abstract could not be selected when defining inheritence for newly created scripts.
Does not change behaviour for in-built abstract classes (which cannot be extended by scripts).
Unsure if this is the best implementation, but it fixes the problem.