Skip to content

Automatically unregister loggers when script language is deinitialized. #109240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Repiteo merged 1 commit into from
Aug 6, 2025
Merged

Automatically unregister loggers when script language is deinitialized. #109240

Repiteo merged 1 commit into from
Aug 6, 2025

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 2, 2025

Fixes #109238

@bruvzg bruvzg added this to the 4.5 milestone Aug 2, 2025
@bruvzg bruvzg requested a review from a team as a code owner August 2, 2025 15:30
@bruvzg bruvzg added the crash label Aug 2, 2025
Calinou
Calinou approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Linux, it works as expected. Code looks good to me.

Custom loggers are new in 4.5, so this can't be cherry-picked.

@Repiteo Repiteo merged commit 5f402da into godotengine:master Aug 6, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Aug 6, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Calinou Calinou Calinou approved these changes

Assignees

No one assigned

Labels

bug crash topic:core

Projects

None yet

Milestone

4.5

Development

Successfully merging this pull request may close these issues.

Using OS.add_logger() causes exported projects to segfault on exit

3 participants

@bruvzg @Repiteo @Calinou