Skip to content

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 18, 2025

@Calinou Calinou requested a review from a team as a code owner August 18, 2025 17:38
@Calinou Calinou added enhancement documentation cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Aug 18, 2025
@Calinou Calinou added this to the 4.5 milestone Aug 18, 2025
@dsnopek
Copy link
Contributor

dsnopek commented Aug 18, 2025

I'm not sure "user-defined class" is the right term. ClassDB does store information about classes defined in GDExtension, which (depending on your perspective) could be considered "user-defined", like if you're using GDExtension for your game logic.

Maybe this should talk about "Classes defined in scripts"?

@Calinou Calinou force-pushed the doc-classdb-no-user-classes branch from e709976 to a7dfa83 Compare August 18, 2025 21:43
@Calinou
Copy link
Member Author

Calinou commented Aug 18, 2025

Maybe this should talk about "Classes defined in scripts"?

Done. I've also added an explicit mention that GDExtension class data is returned by ClassDB.

@Calinou Calinou force-pushed the doc-classdb-no-user-classes branch from a7dfa83 to 336ba21 Compare August 18, 2025 21:44
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me :-)

Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Repiteo Repiteo merged commit 8cb6bb9 into godotengine:master Aug 25, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Aug 25, 2025

Thanks!

@Calinou Calinou deleted the doc-classdb-no-user-classes branch August 25, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants