Fix texture_get_data on D3D12. #111328
Closed
Fix texture_get_data on D3D12. #111328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCube3310
added
the
cherrypick:4.5
clayjohn
reviewed
Oct 6, 2025
Contributor
Author
|
I'm gonna be making a different PR that supersedes this one. |
AThousandShips
added
archived
and removed
cherrypick:4.5
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98527.
Placement alignment was getting respected when creating the readback buffer, but not when actually copying the pixels, which was breaking on D3D12 as it doesn't allow tight alignment by default unlike Vulkan.