Rename glsl variables in glow effect. #111333
Open
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value is. This smoothstep value is not the luminance, it is simply the max value. By using the max value, glow is made to be an effect that helps circumvent the limitations of display technology rather than being related to luminance. Glow could be re-written to be based on luminance, but until then this new variable name is more appropriate.
Calinou
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps reduce confusion among developers about what the
smoothstepvalue of the glow effect is:This smoothstep value is not the luminance, it is simply the max value. By using the max value, glow is made to be an effect that helps circumvent the limitations of display technology rather than being related to luminance. Glow could be re-written to be based on luminance, but until then this new variable name is more appropriate.