GLTF: Support animating node visibility #111341
Open
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I made the visibility PR #93722, the animation pointer PR #94165 was not yet merged. Then I forgot to update PR #93722 to work with PR #94165 after PR #94165 was merged. This PR performs that change, allowing KHR_node_visibility to be animated by KHR_animation_pointer. In master, you can use KHR_node_visibility and KHR_animation_pointer but they cannot work together because this bit of code is missing.
Minimal test files (generated with Godot and imports correctly back into Godot): cube_visibility.zip