Skip to content

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented Oct 7, 2025

The main idea can be referred to thsi thread,

  • Get UID from ".uid" file first (for compatibility).
  • Add a comment line to store UID in GDScript/Shader/ShaderInclude if ".uid" file is invalid.
  • Scripts in “res://addons/” still using ".uid" files, avoid changing content of plugin's scripts.
  • Add settings to enable this feature:
    • "filesystem/inline_text_resource_uids/gdscript"
    • "filesystem/inline_text_resource_uids/shader"
    • "filesystem/inline_text_resource_uids/shader_include"
  • Add setting "filesystem/inline_text_resource_uids/compatibility/no_inline_text_resource_uids_in_addons" to disable this feature in "res://addons".

@Daylily-Zeleen Daylily-Zeleen requested review from a team as code owners October 7, 2025 12:37
@AThousandShips
Copy link
Member

How is this different from:

@AThousandShips AThousandShips added this to the 4.x milestone Oct 7, 2025
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/add_uid_comment_to_gdscript branch from 54c80f0 to cf6ebfe Compare October 7, 2025 12:44
@Daylily-Zeleen
Copy link
Contributor Author

Daylily-Zeleen commented Oct 7, 2025

How is this different from:

I forget that there have #99090 so I make this one.

Some differents:

  • This pr has not any option to enable or disable this feature.
  • This pr will keep exists ".uid" files.
  • This pr still using ".uid" files in "res://addons/" to avoid change content of plugin's scripts. Can disable this feature in "res://addons/" for compatibility.

@AThousandShips
Copy link
Member

I'd say this is fully a duplicate and the specific implementation should be discussed on the other PR

@KoBeWi
Copy link
Member

KoBeWi commented Oct 7, 2025

This pr will keep exists ".uid" files.

It's the same in the other PR. You have to delete .uid files for the comments to be created.

This pr still using ".uid" files in "res://addons/" to avoid change content of plugin's scripts.

That's only useful if addons don't come with UIDs included. I think most active addons are already updated at this point.

@Daylily-Zeleen
Copy link
Contributor Author

Let's discuss in the other pr.

@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/add_uid_comment_to_gdscript branch 4 times, most recently from 9744948 to 107cae5 Compare October 12, 2025 15:18
@Daylily-Zeleen Daylily-Zeleen requested review from a team as code owners October 12, 2025 15:18
@Daylily-Zeleen Daylily-Zeleen force-pushed the daylily-zeleen/add_uid_comment_to_gdscript branch from 107cae5 to b534326 Compare October 12, 2025 15:18
@Daylily-Zeleen Daylily-Zeleen changed the title Add uid comment to gdscript. Inline uid to .gd/.shader/.shaderinc. Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants