Update re-spirv with bugfix for function result decorations. #113582
+200
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will mark this as ready once I've confirmed first that the new code doesn't cause a regression with SpvOpLoad considering all results valid (need to review how it behaves with access chains). |
Contributor
|
when testing this locally, the new re-spirv.cpp fixed my issue 👍 |
Also adds some optimizations to further reduce allocations.
DarioSamo
force-pushed
the
re-spirv-decoration-fix
branch
from
d04ca66 to
040b36f
Compare
Contributor
Author
|
This should now feature the last batch of optimizations I made for the parsing step as well as the bugfix. |
clayjohn
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113561.
While it doesn't seem to have triggered on
masterfor some unknown reason, it seems thatglslangcan insert decorations for in-function results, which were failing to be properly duplicated during re-spirv's inlining pass.This shouldn't be critical to merge now, but it sounds like the issue can pop up when the conditions are right. I ask @CookieBadger to give it a shot at least and confirm if this fixes the issue for them.