Skip to content

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Apr 7, 2022

With a new build script introduced in godotengine/godot-cpp#636 godot-cpp test project automatically build the library, and separate library build step is redundant.

@akien-mga
Copy link
Member

I noticed that too. I think it might be a bug that the test project rebuilds godot-cpp if it was already built, ideally it would reuse the existing build and only rebuild if flags changed.

But if the current behavior is intended, then yes we can remove the first build from CI.

@bruvzg
Copy link
Member Author

bruvzg commented Apr 7, 2022

I think it might be a bug that the test project rebuilds godot-cpp if it was already built, ideally it would reuse the existing build and only rebuild if flags changed.

I'm not sure if it's possible, test project will has its own .sconsign.dblite database in the project folder and use library as a subproject. Scons seems to have an option to set db path, but it's probably won't work if used with multiple projects.

@bruvzg bruvzg marked this pull request as ready for review April 7, 2022 17:21
@bruvzg bruvzg requested a review from a team as a code owner April 7, 2022 17:21
@akien-mga akien-mga merged commit 26879ed into godotengine:master Apr 7, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

It seems to be possible to build test after godot-cpp without rebuilding the library with build_library=no, it's used on CI for godot-cpp: https://github.com/godotengine/godot-cpp/blob/60037decc36e223fbcce78586a26e7dd9468033d/.github/workflows/ci.yml#L76-L83

It's equivalent to building both at once so it's probably fine as is, but if ever start adding more test projects, we could use that.

@bruvzg bruvzg deleted the remove_godotcpp_build branch November 21, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants