Skip to content

Conversation

dask-58
Copy link

@dask-58 dask-58 commented Aug 14, 2025

Closes: #1992

Description:

  • This pull request introduces a new, unified caching layer to Gofr, located in the pkg/cache directory. It establishes a common cache.Cache interface and provides two primary backend implementations: in-memory (with LRU eviction) and Redis.

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

@dask-58
Copy link
Author

dask-58 commented Aug 14, 2025

@coolwednesday This PR is the continuation of old PR. Which resolves the requested changes.

@Umang01-hash
Copy link
Member

@dask-58 Are you still working on this issue? Please let me know if you need any help in proceeding ahead and resolving the review comments.

@dask-58
Copy link
Author

dask-58 commented Sep 8, 2025

@dask-58 Are you still working on this issue? Please let me know if you need any help in proceeding ahead and resolving the review comments.

I've already resolved the review comments.
The only remaining issue is the failing security check, which might be related to the commit ec9a0be. I'd appreciate any fixes for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Unified Cache Layer
4 participants