Skip to content

Conversation

@luiz-otavio
Copy link

Description:
As mentioned in the issue #2341, there are some usecases where custom headers are used for reference or validating of digital signatures which currently cannot be handled by the actual Request interface.

This change comes up with the new methods Headers and Header(key) for implementations such as http/Request to make it public for users on implementating their handling of custom headers.

Additional Information:

  • This implementation is focused specifically for http packages, which is not dealed in other packages such as webservices, grpc or other methods of communication since Headers are handled differently by each one.

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • All new code is covered by unit tests.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

@Umang01-hash
Copy link
Member

@luiz-otavio Thank you for your contribution to GoFr — we truly appreciate your effort!

We noticed that the issue #2341 , which this PR #2345 was addressing, has been closed by you. This suggests that your use case may have been resolved through existing alternatives or no longer requires changes in the framework.

Given that, we’re closing this PR for now to keep the repository clean and focused. If the need resurfaces or you’d like to revisit the solution, feel free to reopen the issue or submit a new PR with updated context.

Thanks again for your engagement and support!

@luiz-otavio
Copy link
Author

@luiz-otavio Thank you for your contribution to GoFr — we truly appreciate your effort!

We noticed that the issue #2341 , which this PR #2345 was addressing, has been closed by you. This suggests that your use case may have been resolved through existing alternatives or no longer requires changes in the framework.

Given that, we’re closing this PR for now to keep the repository clean and focused. If the need resurfaces or you’d like to revisit the solution, feel free to reopen the issue or submit a new PR with updated context.

Thanks again for your engagement and support!

No problem. After dealing with the issue, I had some way of fixing it instead of adding those methods into the api. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants