ssh/server: handle repeated SSH authentication service requests #322
+28
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the SSH server authentication logic by allowing
repeated authentication service requests (SSH_MSG_SERVICE_REQUEST)
during the authentication phase.
Some clients, such as Paramiko send "ssh-userauth" every time before
attempting any authentication method. For example, when trying multiple
keys in a single connection, Paramiko sends a new service request before
each key attempt.
Previously, the server only handled the first request. If that failed,
the connection closed because the implementation was not prepared to
accept further service requests tied to the same SSH_MSG_SERVICE_REQUEST
flow.
With this change, the server can correctly process repeated service
requests, allowing clients to retry authentication with multiple keys
over the same connection.