sort: clarify Less doc #74333

jagprog5 · 2025-06-23T03:20:00Z

clarifies the requirements for Less

jagprog5 · 2025-06-23T03:20:31Z

Original PR: #73421

I accidentally pushed a shallow history. This automatically killed the previous PR and abandoned the Gerrit. I won't make that mistake again :). I have addressed the feedback given by the reviewer.

gopherbot · 2025-06-23T03:25:03Z

This PR (HEAD: d9b8796) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/683275.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-06-23T03:37:50Z

This PR (HEAD: 26fe793) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/683275.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-06-23T16:34:10Z

Message from Keith Randall:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-23T16:41:44Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-06-23T16:22:24Z","revision":"f26ea71e09a356a5c5737a2a60cd0d5a280e1c8c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-23T16:56:38Z

Message from Robert Griesemer:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-23T16:56:39Z

Message from Keith Randall:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-23T16:56:39Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-23T16:56:40Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T18:41:35Z

This PR (HEAD: 7a49ad8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/683275.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-06T18:48:28Z

Message from John G:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T19:44:56Z

Message from Keith Randall:

Patch Set 3: Auto-Submit+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T19:51:28Z

Message from Keith Randall:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T19:57:54Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-06T19:41:30Z","revision":"819225b8b69867db5bece3daf7e6bf84cc30659d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T19:57:55Z

Message from Keith Randall:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T20:04:34Z

Message from Keith Randall:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T20:04:34Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-386 has failed with summary (view all results):

go on master (change 683275)

To reproduce, try gomote repro 8710065879740297985.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T20:04:35Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T20:36:04Z

Message from Keith Randall:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T20:42:38Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-06T20:29:54Z","revision":"819225b8b69867db5bece3daf7e6bf84cc30659d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T21:08:20Z

Message from Keith Randall:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T21:08:21Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-06T21:08:21Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/683275.
After addressing review feedback, remember to publish your drafts!

clarifies the requirements for Less Fixes #73420 Change-Id: I7d49b10fad78c618d946b3bb161ce19680ede47a GitHub-Last-Rev: 7a49ad8 GitHub-Pull-Request: #74333 Reviewed-on: https://go-review.googlesource.com/c/go/+/683275 Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]> Auto-Submit: Keith Randall <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

gopherbot · 2025-07-07T16:24:06Z

This PR is being closed because golang.org/cl/683275 has been merged.

jagprog5 force-pushed the master branch from d9b8796 to 26fe793 Compare June 23, 2025 03:32

sort: clarify doc on less

7a49ad8

jagprog5 force-pushed the master branch from 26fe793 to 7a49ad8 Compare July 6, 2025 18:37

gopherbot closed this Jul 7, 2025

sort: clarify Less doc #74333

sort: clarify Less doc #74333

Conversation

jagprog5 commented Jun 23, 2025

Uh oh!

jagprog5 commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jun 23, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 6, 2025

Uh oh!

gopherbot commented Jul 7, 2025

Uh oh!

Uh oh!