-
Notifications
You must be signed in to change notification settings - Fork 1.2k
net/http2: pool transport gzip readers #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 5e48e81) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710235. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/710235. |
Message from Alexander Yastrebov: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/710235. |
Message from Sean Liao: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/710235. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-08T20:32:55Z","revision":"8e3e4d8fcffc1ff884c8c9290d9b1865375baa7b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/710235. |
Message from Sean Liao: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/710235. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/710235. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/710235. |
Message from Sean Liao: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/710235. |
This is a copy of the CL 510255 with the difference that it preserves use of fs.ErrClosed when reading after close. goos: darwin goarch: arm64 pkg: golang.org/x/net/http2 cpu: Apple M4 │ HEAD~1 │ HEAD │ │ sec/op │ sec/op vs base │ ClientGzip-10 752.8µ ± 1% 750.7µ ± 2% ~ (p=0.393 n=10) │ HEAD~1 │ HEAD │ │ B/op │ B/op vs base │ ClientGzip-10 75.49Ki ± 0% 33.98Ki ± 3% -54.99% (p=0.000 n=10) │ HEAD~1 │ HEAD │ │ allocs/op │ allocs/op vs base │ ClientGzip-10 705.0 ± 0% 698.5 ± 0% -0.92% (p=0.000 n=10) Updates golang/go#61353
5e48e81
to
4d04dc9
Compare
This PR (HEAD: 4d04dc9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/710235. Important tips:
|
Message from Alexander Yastrebov: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/710235. |
This is a copy of the CL 510255 with the difference that
it preserves use of fs.ErrClosed when reading after close.
goos: darwin
goarch: arm64
pkg: golang.org/x/net/http2
cpu: Apple M4
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
ClientGzip-10 752.8µ ± 1% 750.7µ ± 2% ~ (p=0.393 n=10)
ClientGzip-10 75.49Ki ± 0% 33.98Ki ± 3% -54.99% (p=0.000 n=10)
ClientGzip-10 705.0 ± 0% 698.5 ± 0% -0.92% (p=0.000 n=10)
Updates golang/go#61353