Skip to content

goimports: add capability to use go.mod module path as prefix #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+19 −1
Open

goimports: add capability to use go.mod module path as prefix #496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c96d6a
goimports use go.mod module path as prefix
TheoBrigitte Jun 1, 2024
b7472e5
trigger ci
TheoBrigitte Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion cmd/goimports/goimports.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"runtime/pprof"
"strings"

"golang.org/x/mod/modfile"
"golang.org/x/tools/internal/gocommand"
"golang.org/x/tools/internal/imports"
)
Expand Down Expand Up @@ -51,7 +52,7 @@ var (

func init() {
flag.BoolVar(&options.AllErrors, "e", false, "report all errors (not just the first 10 on different lines)")
flag.StringVar(&options.LocalPrefix, "local", "", "put imports beginning with this string after 3rd-party packages; comma-separated list")
flag.StringVar(&options.LocalPrefix, "local", "", "put imports beginning with this string after 3rd-party packages; comma-separated list; if set to auto, use module path from go.mod as prefix")
flag.BoolVar(&options.FormatOnly, "format-only", false, "if true, don't fix imports and only format. In this mode, goimports is effectively gofmt, with the addition that imports are grouped into sections.")
}

Expand Down Expand Up @@ -268,6 +269,23 @@ func gofmtMain() {
return
}

if options.LocalPrefix == "auto" {
wd, err := os.Getwd()
if err != nil {
log.Fatal(err)
}
filename := filepath.Join(wd, "go.mod")
data, err := os.ReadFile(filename)
if err != nil {
log.Fatal(err)
}
gomodModulePath := modfile.ModulePath(data)
if err != nil {
log.Fatal(err)
}
options.LocalPrefix = gomodModulePath
}

if len(paths) == 0 {
if err := processFile("<standard input>", os.Stdin, os.Stdout, fromStdin); err != nil {
report(err)
Expand Down