-
Notifications
You must be signed in to change notification settings - Fork 2.3k
gopls: fix extracted function shouldReturn boolean return value position #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 8fe03ee) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/705115. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/705115. |
Message from Fata Nugraha: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/705115. |
Message from Alan Donovan: Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/705115. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-18T23:51:13Z","revision":"ebfdd6c38e68f3a1bfe9436bff12a9315a197a03"} Please don’t reply on this GitHub thread. Visit golang.org/cl/705115. |
Message from Alan Donovan: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/705115. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/705115. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/705115. |
In the extracted function, the shouldReturn boolean return value should be put after the existing return values. Fixes golang/go#75527 Change-Id: I7983784cf9c23615f7a6850fda50f26df9ca295c GitHub-Last-Rev: 8fe03ee GitHub-Pull-Request: #592 Reviewed-on: https://go-review.googlesource.com/c/tools/+/705115 Reviewed-by: Alan Donovan <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Auto-Submit: Alan Donovan <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/705115 has been merged. |
In the extracted function, the shouldReturn boolean return value should be
put after the existing return values.
Fixes golang/go#75527