-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: more generic url #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
racinmat
wants to merge
9
commits into
google:main
Choose a base branch
from
racinmat:a2a-url-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: more generic url #2556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Response from ADK Triaging Agent Hello @racinmat, thank you for creating this PR! To help reviewers better understand and test your changes, could you please add a Thanks! |
@adk-bot I modified description of the PR by adding |
This was referenced Aug 15, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2238.
Makes the logic changed by #2520 flexible and usable by agents defined in the same application.
Supersedes #2251 because that did not get requested for review and adk-bot was not triggered there for some reason.
This is more generic and allows you to set http or https as needed, which is crucial in larger ecosystems.
And it lets you nest the FastAPI into a subapp, because you can specify the base url including the path of the sub-app.
If the
url
parameter in agent card is empty string, it will be filled from the application. This lets you either hardcode the agent url or let it be defined from the code.testing plan
The tests can be seen in the PR.
I removed the mock to actually exercise the A2A-related code which was just silently crashing until now.
Now, with this with, you can run
and the a2a agent will be exposed on the localhost. And if you will run the code in different environments, you can parameterize them now, and pass the URL e.g. from environment variable, which wasn't possible after merging #2520.