-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: adk deploy docker file file permission #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Vicente Ferrara <[email protected]>
Response from ADK Triaging Agent Hello @moficodes, thank you for creating this PR! This PR is a bug fix, could you please associate the github issue with this PR? If there is no existing issue, could you please create one? In addition, could you please include a This information will help reviewers to review your PR more efficiently. Thanks! |
@moficodes could you provide your testing plan? |
Please also provide an instruction on how to test this. |
The way to test the command out would be through the new
This is going to create a Deployment and Service K8s resources that you will see in your cluster and then a pod will be running. Verify the deployment using
kubectl get pods You should see output like
kubectl get service
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
adk-default-service-name LoadBalancer 34.118.228.70 34.63.153.253 80:32581/TCP 5d20h Navigate to the EXTERNAL-IP and interact with your agent via the UI. |
Co-authored-by: Vicente Ferrara <[email protected]>
2896620
to
ab384be
Compare
/retest |
Could you run the test again? |
Hi @moficodes I just triggered the flow, it seems that you need to run the autoformat.sh in the repo to format your change. |
Co-authored-by: Vicente Ferrara <[email protected]>
516412d
to
47b393b
Compare
Formatted. One more test run. :) |
Merge #2563 Currently in adk deploy cloud_run or gke, the dockerfile copies the agent code after the file permission is set. This can lead to file permission not being set correctly for the container to open and read the file. This PR will make sure the files are copied with the permission of the user that is set in the container. COPYBARA_INTEGRATE_REVIEW=#2563 from moficodes:deploy-docker d7f6df4 PiperOrigin-RevId: 799371070
merged in ad81aa5 Thanks @moficodes and @vicentefb for the help! |
Currently in adk deploy cloud_run or gke, the dockerfile copies the agent code after the file permission is set. This can lead to file permission not being set correctly for the container to open and read the file.
This PR will make sure the files are copied with the permission of the user that is set in the container.