Skip to content

fix typo #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Open

fix typo #2586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c09c563
Update local_eval_service.py
FingerLiu Aug 18, 2025
8a2654a
Update test_local_eval_service.py
FingerLiu Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/google/adk/evaluation/local_eval_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ async def perform_inference(

async def run_inference(eval_case):
async with semaphore:
return await self._perform_inference_sigle_eval_item(
return await self._perform_inference_single_eval_item(
app_name=inference_request.app_name,
eval_set_id=inference_request.eval_set_id,
eval_case=eval_case,
Expand Down Expand Up @@ -342,7 +342,7 @@ def _generate_final_eval_status(

return final_eval_status

async def _perform_inference_sigle_eval_item(
async def _perform_inference_single_eval_item(
self,
app_name: str,
eval_set_id: str,
Expand Down
10 changes: 5 additions & 5 deletions tests/unittests/evaluation/test_local_eval_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ async def test_perform_inference_success(
mock_eval_sets_manager.get_eval_set.return_value = eval_set

mock_inference_result = mock.MagicMock()
eval_service._perform_inference_sigle_eval_item = mock.AsyncMock(
eval_service._perform_inference_single_eval_item = mock.AsyncMock(
return_value=mock_inference_result
)

Expand All @@ -146,7 +146,7 @@ async def test_perform_inference_success(
mock_eval_sets_manager.get_eval_set.assert_called_once_with(
app_name="test_app", eval_set_id="test_eval_set"
)
assert eval_service._perform_inference_sigle_eval_item.call_count == 2
assert eval_service._perform_inference_single_eval_item.call_count == 2


@pytest.mark.asyncio
Expand All @@ -166,7 +166,7 @@ async def test_perform_inference_with_case_ids(
mock_eval_sets_manager.get_eval_set.return_value = eval_set

mock_inference_result = mock.MagicMock()
eval_service._perform_inference_sigle_eval_item = mock.AsyncMock(
eval_service._perform_inference_single_eval_item = mock.AsyncMock(
return_value=mock_inference_result
)

Expand All @@ -182,13 +182,13 @@ async def test_perform_inference_with_case_ids(
results.append(result)

assert len(results) == 2
eval_service._perform_inference_sigle_eval_item.assert_any_call(
eval_service._perform_inference_single_eval_item.assert_any_call(
app_name="test_app",
eval_set_id="test_eval_set",
eval_case=eval_set.eval_cases[0],
root_agent=dummy_agent,
)
eval_service._perform_inference_sigle_eval_item.assert_any_call(
eval_service._perform_inference_single_eval_item.assert_any_call(
app_name="test_app",
eval_set_id="test_eval_set",
eval_case=eval_set.eval_cases[2],
Expand Down