-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: return invocation_id when using tools + output_schema #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return invocation_id when using tools + output_schema #2640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dylan-apex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug where the invocation_id
was not being included in the final model response event when LLM flows utilized tools and output schemas. The change ensures that this crucial identifier is consistently returned, thereby improving traceability and debugging capabilities for these specific interaction patterns within the system.
Highlights
- Event Creation Enhancement: The
create_final_model_response_event
function in_output_schema_processor.py
has been updated to explicitly pass theinvocation_id
from theinvocation_context
to theEvent
constructor. This ensures that the unique identifier for an invocation is always present in the final model response event.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a bug where the invocation_id
was not being set on events created when using an output_schema
with tools. The change correctly passes the invocation_id
from the invocation_context
when creating the final model response event. This is a good fix. I've also suggested propagating the branch
from the context for better consistency and to support sub-agent scenarios correctly.
Response from ADK Triaging Agent Hello @dylan-apex, thank you for creating this PR! To help reviewers better understand and test your fix, could you please add a This information will help reviewers to review your PR more efficiently. Thanks! |
@Jacksunwei Noting that I added more after you approved the PR |
Overshadowed by #2648 |
Fixes #2631