-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: Add custom User-Agent header to RestApiTool requests #2641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @rcsantana777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new feature to enhance the traceability of API requests originating from the ADK. By adding a custom User-Agent header to all requests made via the RestApiTool
, backend services will now be able to identify and differentiate traffic coming from the ADK. This change is crucial for monitoring and analytics, providing better insights into the source of API calls.
Highlights
- User-Agent Header Addition: A custom User-Agent header, specifically "google-adk/1.0", has been implemented for all requests originating from the
RestApiTool
. This allows backend services to accurately identify traffic from the ADK.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Response from ADK Triaging Agent Hello @rcsantana777, thank you for creating this PR! To help reviewers evaluate your contribution more efficiently, could you please address the following points from our contribution guidelines?
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a custom User-Agent header to requests made via RestApiTool
. The change is good for identifying traffic from the ADK. My feedback focuses on improving maintainability by replacing the hardcoded User-Agent string with a constant and cleaning up the code formatting for better readability.
src/google/adk/tools/openapi_tool/openapi_spec_parser/rest_api_tool.py
Outdated
Show resolved
Hide resolved
src/google/adk/tools/openapi_tool/openapi_spec_parser/rest_api_tool.py
Outdated
Show resolved
Hide resolved
efa792e
to
ed5c3a3
Compare
could you please run |
4133515
to
c0c465e
Compare
d7ecf5a
to
8065361
Compare
This PR adds a custom
User-Agent
header to all requests made viaRestApiTool
. This allows backend services to identify traffic originating from the ADK. The header format isgoogle-adk/<version> (tool: <tool_name>)
, where<version>
is the current version of thegoogle-adk
package, fetched dynamically fromgoogle.adk.version
, and<tool_name>
is the name of the specificRestApiTool
instance.Associated Issue
Fixes #2676
Testing Plan
Unit Tests
I ran the full suite of unit tests locally to ensure the changes did not introduce any regressions. All tests passed successfully.
$ pytest ./tests/unittests ================================= 4202 passed, 2459 warnings in 44.68s ====================
The warnings are related to existing experimental features and are not affected by this change.
Manual End-to-End (E2E) Test
I performed a manual test to ensure the integrated flow works as expected.
Setup: Created a clean virtual environment (
~/venvs/adk-e2e-test
) and installed the locally builtgoogle-adk
package usinguv venv --seed
andpip install dist/google_adk-*.whl
. Ran a custommock_server.py
script (using Flask) in one terminal to listen for requests and print headers. Ran a customrun_test_tool.py
script in a second terminal to send a request using the modifiedRestApiTool
.Execution: The
run_test_tool.py
script successfully sent a POST request to the mock server's/test
endpoint. The mock server received the request and printed the headers.run_test_tool.py
Output:mock_server.py
Output (Headers):The
User-Agent: google-adk/1.12.0 (tool: TestTool)
header confirms the change is working as intended, dynamically fetching the package version and including the tool name.Checklist
./autoformat.sh