Migrate controller e2e tests to use Controller CLI

[ndegwamartin]

Description of what I changed

resolves #1430

E2E test

TESTED:

Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.

Checklist: I completed these to help reviewers :)

• I have read and will follow the
  review process.

• I am familiar with Google Style Guides for the language I have coded in.

  No? Please take some time and review
  Java and
  Python style guides.

• My IDE is configured to follow the Google
  code styles.

  No? Unsure? ->
  configure your IDE.

• I have added tests to cover my changes. (If you refactored existing
  code that was well tested you do not have to add tests)

• I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.

• If I made any Python code changes, I ran black . and pylint . right
  before creating this pull request and added all formatting changes to my
  commit.

• All new and existing tests passed.

• My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.62%. Comparing base (a70dab1) to head (cc3968c).

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1461      +/-   ##
============================================
- Coverage     46.66%   46.62%   -0.04%     
  Complexity      676      676              
============================================
  Files            90       90              
  Lines          5874     5874              
  Branches        814      814              
============================================
- Hits           2741     2739       -2     
- Misses         2828     2830       +2     
  Partials        305      305              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ndegwamartin]

/gcbrun

[ndegwamartin]

/gcbrun

[ndegwamartin]

/gcbrun

[ndegwamartin]

/gcbrun

[ndegwamartin]

/gcbrun

[ndegwamartin]

/gcbrun

[bashir2]

/gcbrun

[bashir2]

The changes look fine to me, I have been just waiting for a green build which I don't think I ever saw on this PR yet, did you @ndegwamartin ?

[bashir2]

So @ndegwamartin I think the reason that we never got a green e2e for this is probably because there is a legitimate failure (and not just flaky issue). Here is a relevant error log from the latest e2e run:

ERROR:root:An error occurred during the request: 500 Server Error:  for url: http://pipeline-controller:8080/run?runMode=INCREMENTAL
Command: run 
Request url: http://pipeline-controller:8080
Response:
null
parse error: Unfinished JSON term at EOF at line 6, column 0

And then it causes the incremental step to fail at counting number of resources (probably because the incremental step is never run).

[ndegwamartin]

/gcbrun

[ndegwamartin]

/gcbrun

[ndegwamartin]

/gcbrun

[ndegwamartin]

/gcbrun

[ndegwamartin]

/gcbrun