Skip to content

string use CompareOrdinal instead string.CompareTo, sort by Unicode o… #8616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

string use CompareOrdinal instead string.CompareTo, sort by Unicode o… #8616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 28 additions & 7 deletions src/idl_gen_csharp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,12 +620,27 @@ class CSharpGenerator : public BaseGenerator {
std::string GenKeyGetter(flatbuffers::StructDef &struct_def,
flatbuffers::FieldDef *key_field) const {
// Get the getter for the key of the struct.
return GenGetterForLookupByKey(struct_def, key_field, "builder.DataBuffer",
"builder.DataBuffer.Length - o1.Value") +
".CompareTo(" +
GenGetterForLookupByKey(struct_def, key_field, "builder.DataBuffer",
"builder.DataBuffer.Length - o2.Value") +
")";
if (GenTypeGet(key_field->value.type) == "string") {
return "string.CompareOrdinal(" +
GenGetterForLookupByKey(struct_def, key_field, "builder.DataBuffer",
"builder.DataBuffer.Length - o1.Value") +
"," +
GenGetterForLookupByKey(struct_def, key_field,
"builder.DataBuffer",
"builder.DataBuffer.Length - o2.Value") +
")";
}
else
{
return GenGetterForLookupByKey(struct_def, key_field,
"builder.DataBuffer",
"builder.DataBuffer.Length - o1.Value") +
".CompareTo(" +
GenGetterForLookupByKey(struct_def, key_field,
"builder.DataBuffer",
"builder.DataBuffer.Length - o2.Value") +
")";
}
}

// Get the value of a table verification function start
Expand Down Expand Up @@ -1539,7 +1554,13 @@ class CSharpGenerator : public BaseGenerator {
"(start + middle), bb);\n";

code += " obj_.__assign(tableOffset, bb);\n";
code += " int comp = obj_." + name + ".CompareTo(key);\n";
if (GenTypeGet(key_field->value.type) == "string") {
code += " int comp = string.CompareOrdinal(obj_." + name + ",key);\n";
}
else
{
code += " int comp = obj_." + name + ".CompareTo(key);\n";
}
code += " if (comp > 0) {\n";
code += " span = middle;\n";
code += " } else if (comp < 0) {\n";
Expand Down