Skip to content

Add bounds checking to a C# method where it was missing #8673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2025
Merged

Add bounds checking to a C# method where it was missing #8673

merged 3 commits into from
Aug 28, 2025

Conversation

CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Aug 14, 2025 •
edited
Loading

Adds bounds checking to an implementation of ByteBuffer.GetStringUTF8 where it was missing when the build-time variable BYTEBUFFER_NO_BOUNDS_CHECK isn't set.

Closes #8672.

@github-actions github-actions bot added the c# label Aug 14, 2025
bjornharrtell
bjornharrtell reviewed Aug 24, 2025
View reviewed changes
Copy link
Collaborator

@bjornharrtell bjornharrtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjornharrtell
Copy link
Collaborator

@aardappel consider merge

@aardappel aardappel merged commit a6b337f into google:master Aug 28, 2025
49 checks passed
@adamreeve adamreeve mentioned this pull request Sep 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornharrtell bjornharrtell bjornharrtell left review comments

@aardappel aardappel aardappel approved these changes

Assignees

No one assigned

Labels

c#

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

C# implementation of ByteBuffer.GetStringUTF8 doesn't have bounds check

3 participants

@CurtHagenlocher @bjornharrtell @aardappel