Skip to content

fix(tty): handle SendSignal error to prevent infinite loop #12362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GHOryy5 wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −2
Open

fix(tty): handle SendSignal error to prevent infinite loop #12362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d48ad70
fix(tty): handle SendSignal error to prevent infinite loop
GHOryy5 Dec 9, 2025
6cbaff1
fixup! remove double SendSignal call and handle error correctly
GHOryy5 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions pkg/sentry/kernel/tty.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,14 @@ func (tty *TTY) CheckChange(ctx context.Context, sig linux.Signal) error {
// handle -ERESTARTSYS in kernel.runApp.execute() even if the
// kernel.Task isn't interrupted.
//
// Linux ignores the result of kill_pgrp().
_ = pg.SendSignal(SignalInfoPriv(sig))
// Linux ignores the result of kill_pgrp(), but relies on setting TIF_SIGPENDING
// to ensure the process handles the signal. In gVisor, if SendSignal fails,
// the signal is not pending. Returning ERESTARTSYS without a pending signal
// causes an infinite tight loop. We must abort if signaling fails.
if err := pg.SendSignal(SignalInfoPriv(sig)); err != nil {
// Signal failed to queue. We cannot return ERESTARTSYS or we loop.
return linuxerr.EIO
}

return linuxerr.ERESTARTSYS
}