Skip to content

Conversation

@nicolasgarza
Copy link

Removes most uses of SliceHeader as referenced by #8422

SliceHeader is deprecated - so we prefer to use unsafe.Slice() and unsafe.Pointer().

@google-cla
Copy link

google-cla bot commented Dec 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ayushr2
Copy link
Collaborator

ayushr2 commented Dec 12, 2025

Also please squash all your commits:

gvisor/CONTRIBUTING.md

Lines 95 to 99 in 63343ff

When iterating on a pull request, please amend your commit rather than creating
new commits on the same branch. Our merge bot applies all commits from the
branch to master and does not yet support squash merging. If you'd like to
submit a pull request with multiple commits, please ensure they are independent,
logical units of work that can be applied separately.

@ayushr2
Copy link
Collaborator

ayushr2 commented Dec 13, 2025

Thanks for your contribution!

copybara-service bot pushed a commit that referenced this pull request Dec 13, 2025
Removes most uses of SliceHeader as referenced by #8422

SliceHeader is deprecated - so we prefer to use unsafe.Slice() and unsafe.Pointer().

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12368 from nicolasgarza:remove-slice-header c73437c
PiperOrigin-RevId: 843970549
also, add memutil, sharedmem_unsafe to nogo to fix build errors (false positive on analyze)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants