tcpip: fix IP_MTU_DISCOVER flag for tcp and udp #12382
Open
+45
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaltinaydev
reviewed
Dec 15, 2025
| switch transErr.Kind() { | ||
| case stack.PacketTooBigTransportError: | ||
| handlePacketTooBig(transErr.Info()) | ||
| if e.pmtud == tcpip.PMTUDiscoveryProbe { |
There was a problem hiding this comment.
Needs a lock here?
e.mu.Lock()
pmtud := e.pmtud
e.mu.Unlock()
if pmtud == tcpip.PMTUDiscoveryProbe {
e.onICMPError(&tcpip.ErrMessageTooLong{}, transErr, pkt)
} else {
handlePacketTooBig(transErr.Info())
}
aaltinaydev
reviewed
Dec 15, 2025
|
|
||
| case tcpip.MTUDiscoverOption: | ||
| switch v := tcpip.PMTUDStrategy(v); v { | ||
| case tcpip.PMTUDiscoveryWant, tcpip.PMTUDiscoveryDont, tcpip.PMTUDiscoveryDo: |
There was a problem hiding this comment.
Should we change this to the following?
case tcpip.PMTUDiscoveryWant, tcpip.PMTUDiscoveryDont, tcpip.PMTUDiscoveryDo, tcpip.PMTUDiscoveryProbe:
e.LockUser()
e.pmtud = v
e.UnlockUser()
default:
return &tcpip.ErrNotSupported{}
}
aaltinaydev
reviewed
Dec 15, 2025
aaltinaydev
left a comment
aaltinaydev
left a comment
There was a problem hiding this comment.
Test needs to be updated at third_party/gvisor/test/syscalls/linux/tcp_socket.cc Line:2360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcpip: fix IP_MTU_DISCOVER flag for tcp and udp
Fixes #12319
This patch only supports various IP_MTU_DISCOVER flags.
To fully support
tracepathactually tracing the path the correct propagation of TTL exceeded is needed.FUTURE_COPYBARA_INTEGRATE_REVIEW=#12366 from pkit:pmtu_probe_support 5ca5162