Skip to content

Add flag to use dpa in grok #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add flag to use dpa in grok #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions paxml/tasks/lm/params/nvidia.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,7 @@ class Grok(NVIDIA1_3B):
DCN_MESH_SHAPE = [1, 32, 1, 1]

USE_ROPE = True
USE_TE_DPA=False

def task(self) -> pax_fiddle.Config[tasks_lib.SingleTask]:
task_p = super().task()
Expand Down Expand Up @@ -802,6 +803,7 @@ def task(self) -> pax_fiddle.Config[tasks_lib.SingleTask]:
combine_qkv=self.COMBINE_QKV,
checkpoint_policy=self.CHECKPOINT_POLICY,
use_fp8=self.USE_FP8,
use_te_dpa=self.USE_TE_DPA,
)
## set sharding
lm_cls = cast(
Expand Down Expand Up @@ -860,6 +862,7 @@ class Grok_Proxy(NVIDIA1_3B):
DCN_MESH_SHAPE = [1, 8, 1, 1]

USE_ROPE = True
USE_TE_DPA=False

def task(self) -> pax_fiddle.Config[tasks_lib.SingleTask]:
task_p = super().task()
Expand Down Expand Up @@ -889,6 +892,7 @@ def task(self) -> pax_fiddle.Config[tasks_lib.SingleTask]:
combine_qkv=self.COMBINE_QKV,
checkpoint_policy=self.CHECKPOINT_POLICY,
use_fp8=self.USE_FP8,
use_te_dpa=self.USE_TE_DPA,
)
## set sharding
lm_cls = cast(
Expand Down Expand Up @@ -953,6 +957,7 @@ class Grok_Proxy_PP(NVIDIA5B):
MESH_AXIS_NAMES = ['stage', 'replica', 'data', 'data_expert', 'mdl']

USE_ROPE = True
USE_TE_DPA=False

def task(self) -> pax_fiddle.Config[tasks_lib.SingleTask]:
task_p = super().task()
Expand Down Expand Up @@ -984,6 +989,7 @@ def task(self) -> pax_fiddle.Config[tasks_lib.SingleTask]:
num_pipeline_stages=self.NUM_STAGES,
num_pipeline_microbatches=self.NUM_MICROBATCHES,
use_fp8=self.USE_FP8,
use_te_dpa=self.USE_TE_DPA,
)
## set sharding
replica_axis='replica'
Expand Down