Skip to content

automatically build Python wheels with cibuildwheel and test with pytest #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

automatically build Python wheels with cibuildwheel and test with pytest #406

wants to merge 6 commits into from

Conversation

@zacharyburnett
Copy link

@zacharyburnett zacharyburnett commented Jan 26, 2025 •
edited
Loading

closes #389, blocked by #390

@zacharyburnett zacharyburnett mentioned this pull request Jan 29, 2025
Merged
@zacharyburnett zacharyburnett changed the title build Python wheels with cibuildwheel build Python wheels with cibuildwheel and test with pytest Jan 29, 2025
@zacharyburnett zacharyburnett changed the title build Python wheels with cibuildwheel and test with pytest automatically build Python wheels with cibuildwheel and test with pytest Jan 29, 2025
@zacharyburnett
Copy link
Author

zacharyburnett commented Jan 29, 2025 •
edited
Loading

The current blocking issue with building is that repairwheel can't find the C extension in the built wheel. Perhaps it is not included for some reason, maybe an issue with the setuptools config:

Repairing wheel...

    + sh -c 'auditwheel repair -w /tmp/cibuildwheel/repaired_wheel /tmp/cibuildwheel/built_wheel/s2geometry-0.0.0-cp37-cp37m-linux_x86_64.whl'
INFO:auditwheel.main_repair:Repairing s2geometry-0.0.0-cp37-cp37m-linux_x86_64.whl
INFO:auditwheel.main_repair:This does not look like a platform wheel, no ELF executable or shared library file (including compiled Python C extension) found in the wheel archive

@zacharyburnett zacharyburnett force-pushed the python_wheels branch 2 times, most recently from 7408992 to dceaa00 Compare June 16, 2025 17:30
b4rdos
b4rdos reviewed Jul 23, 2025
View reviewed changes
pyproject.toml
name = "s2geometry"
description = "Computational geometry and spatial indexing on the sphere"
authors = [
{ name = "Dan Larkin-York", email = "[email protected]" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use a formatter for this? Is the formatter tool / version recorded somewhere?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used taplo fmt to format this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@b4rdos b4rdos b4rdos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use cibuildwheel for Python CI

2 participants

@zacharyburnett @b4rdos