-
Notifications
You must be signed in to change notification settings - Fork 336
exactfloat: Remove OpenSSL dependency #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 25 commits
877fb4a
383f43b
71314f0
f374cb3
54244eb
640f6b3
b2f72d3
095e140
ddc7b69
29be9ff
308698e
7e90c5c
81f846a
c675cca
593414d
f075655
5853f70
a470ace
f9697b1
746be61
d1b6920
eb1d501
dde62ae
f434e10
05a39ae
26b180b
6d5b227
05605ea
4fc8806
1bbe409
4a4380b
fc43b3c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,37 @@ | ||
| package(default_visibility = ["//visibility:public"]) | ||
|
|
||
| cc_library( | ||
| name = "bignum", | ||
| srcs = ["bignum.cc"], | ||
| hdrs = ["bignum.h"], | ||
| visibility = ["//visibility:private"], | ||
| deps = [ | ||
| "@abseil-cpp//absl/algorithm:container", | ||
| "@abseil-cpp//absl/container:inlined_vector", | ||
| "@abseil-cpp//absl/log:absl_check", | ||
| ], | ||
| ) | ||
|
|
||
| cc_library( | ||
| name = "exactfloat", | ||
| srcs = ["exactfloat.cc"], | ||
| hdrs = ["exactfloat.h"], | ||
| deps = [ | ||
| ":bignum", | ||
| "//s2/base:logging", | ||
| "@abseil-cpp//absl/log:log", | ||
| "@abseil-cpp//absl/log:absl_check", | ||
| ], | ||
| ) | ||
|
|
||
| cc_test( | ||
| name = "bignum_test", | ||
| srcs = ["bignum_test.cc"], | ||
| deps = [ | ||
| ":bignum", | ||
| "//:s2_testing_headers", | ||
| "@abseil-cpp//absl/log:log_streamer", | ||
| "@abseil-cpp//absl/random:bit_gen_ref", | ||
| "@boringssl//:crypto", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I asked a couple of questions about this on a previous comment, but github apparently doesn't see fit to mark the conversations as unresolved and so I'm guessing you never saw those questions. Essentially, I'm asking whether these benchmarks are important enough that we want to continue to have a dependency on OpenSSL, even if it's just for testing purposes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Up to @jmr, it's easier to live with if it's just for testing. |
||
| "@googletest//:gtest_main", | ||
| ], | ||
| ) | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.