Refactor custom node type checking and template handling. #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_842830485
branch
5 times, most recently
from
9f143b6 to
127f48f
Compare
copybara-service
bot
force-pushed
the
test_842830485
branch
from
127f48f to
56c1e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor custom node type checking and template handling.
This change introduces a new
isCustomNodefunction that uses duck typing to check forCustomNodeinstances, making it more robust against potential module import issues. Thedirected_acyclic_graph_rawcomponent now uses this new function and also correctly passescustomNodeTemplatesto the raw component. The logic for fetching control nodes for groups has also been updated.DagGroup - CustomControlNode didn't render when isExpanded was used see
DEMO = Group node rendered