Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Aug 22, 2024

Part of enabling hermetic code generation in this repo. more context.

@diegomarquezp diegomarquezp requested review from a team as code owners August 22, 2024 14:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Aug 22, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this file is still used in hermetic build scripts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it was the wrong file. I fixed it so we delete OwlBot.lock.yaml instead.

@JoeWang1127
Copy link
Contributor

Could you also remove the image url in .OwlBot-hermetic.yaml?

@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Sep 5, 2024

Could you also remove the image url in .OwlBot-hermetic.yaml?

@JoeWang1127 I just created a PR for that task.

#2333

@diegomarquezp diegomarquezp merged commit b38c6f4 into main Sep 5, 2024
@diegomarquezp diegomarquezp deleted the diegomarquezp-patch-2 branch September 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants