-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(ui): resolve type errors #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Corrects a typo in `ui/communication/failure/code.gs`. - Adds JSDoc annotations to `ui/communication/private/code.gs`, `ui/communication/runner.gs`, and `ui/forms/code.gs` to resolve type errors. - Adds trailing newlines to `ui/communication/failure/code.gs` and `ui/communication/private/code.gs`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
jpoehnelt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice catch on the gotInboxUnreadCount typo.
| return email + ' has $1,000,000 in the bank.'; | ||
| } | ||
| // Do some secret calculations | ||
| return email + ' has $1,000,000 in the bank.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer template literal
| /** | ||
| * @type {{script: {run: GoogleScriptRun}}} | ||
| */ | ||
| var google = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
google is a global here. use any
This pull request fixes TypeScript errors in the
uidirectory by adding JSDoc annotations, correcting a typo, and ensuring all files end with a newline. All changes adhere to the project's coding standards and pass the type checker.PR created automatically by Jules for task 11415909359933698018 started by @jpoehnelt