Skip to content

fix: ensure default model is parsed when using default model provider #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: ensure default model is parsed when using default model provider #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/remote/remote.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,12 @@ func (c *Client) Call(ctx context.Context, messageRequest types.CompletionReques
return nil, fmt.Errorf("failed to find remote model %s", messageRequest.Model)
}

_, modelName := types.SplitToolRef(messageRequest.Model)
toolName, modelName := types.SplitToolRef(messageRequest.Model)
if modelName == "" {
// modelName is empty, then the messageRequest.Model is not of the form 'modelName from provider'
// Therefore, the modelName is the toolName
modelName = toolName
}
messageRequest.Model = modelName
return client.Call(ctx, messageRequest, status)
}
Expand Down