Skip to content

Conversation

njhale
Copy link
Member

@njhale njhale commented Aug 5, 2024

Remove the ability to start the UI tool from gptscript. This drops the
--ui flag from the gptscript command.

Note: Let's hold off on merging this until electron support is merged into https://github.com/gptscript-ai/ui.

Remove the ability to start the UI tool from gptscript. This drops the
`--ui` flag from the gptscript command.

Signed-off-by: Nick Hale <[email protected]>
@njhale njhale force-pushed the enhance/remove-ui-option branch from ae07224 to ceed1e0 Compare August 5, 2024 19:30
@njhale njhale marked this pull request as ready for review August 7, 2024 22:32
@njhale njhale requested review from thedadams and tylerslaton August 7, 2024 22:32
Copy link
Contributor

@thedadams thedadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Should we also remove the workflow that tags the UI? Last I heard, the UI electron app was going to be on a slightly different release cycle.

@njhale
Copy link
Member Author

njhale commented Aug 7, 2024

@thedadams

Should we also remove the workflow that tags the UI? Last I heard, the UI electron app was going to be on a slightly different release cycle

I think that's a good idea since there's currently at least one manual step -- bumping the version field in the package.json file -- to releasing the UI. As it stands, we'll end up inadvertently updating the published builds for the previous release of the UI when gptscript releases.

I'll drop the workflow now.

@njhale
Copy link
Member Author

njhale commented Aug 7, 2024

done

@njhale njhale requested a review from thedadams August 7, 2024 22:56
@njhale njhale marked this pull request as draft August 8, 2024 18:33
@njhale
Copy link
Member Author

njhale commented Nov 20, 2024

This is stale, going to close out.

@njhale njhale closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants