Skip to content

fix: send proper SSE for stderr message in SDK server #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: send proper SSE for stderr message in SDK server #862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/sdkserver/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ func processEventStreamOutput(ctx context.Context, logger mvl.Logger, w http.Res
"stdout": out,
})
case err := <-errChan:
writeError(logger, w, http.StatusInternalServerError, fmt.Errorf("failed to run file: %w", err))
writeServerSentEvent(logger, w, map[string]any{
"stderr": fmt.Sprintf("failed to run: %v", err),
})
}

// Now that we have received all events, send the DONE event.
Expand Down