Skip to content

Standalone: call out exceptions at the top of results #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2023
Merged

Standalone: call out exceptions at the top of results #3156

merged 2 commits into from
Nov 29, 2023

Conversation

greggman
Copy link
Contributor

Issue: #3147

This was the simplest thing I could think of.

@greggman greggman requested a review from kainino0x November 10, 2023 09:10
@kainino0x kainino0x mentioned this pull request Nov 13, 2023
Open
7 tasks
kainino0x
kainino0x reviewed Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK but I think I'd prefer to do something for all runtimes, propose #3163

@greggman greggman mentioned this pull request Nov 27, 2023
Merged
7 tasks
@kainino0x kainino0x enabled auto-merge (squash) November 29, 2023 04:01
@kainino0x kainino0x disabled auto-merge November 29, 2023 04:01
@kainino0x kainino0x changed the title Callout exceptions at the top of results Standalone: call out exceptions at the top of results Nov 29, 2023
@kainino0x kainino0x enabled auto-merge (squash) November 29, 2023 04:01
@kainino0x kainino0x merged commit 2979ce0 into gpuweb:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greggman @kainino0x