Demo for 7 #4
Open
Demo for 7 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donat
force-pushed
the
donat/demo-milestone-7
branch
7 times, most recently
from
4e9711e to
2ba1e04
Compare
tresat
requested changes
Nov 20, 2025
Member
tresat
left a comment
tresat
left a comment
There was a problem hiding this comment.
Demo looks good, my comments are about removing unnecessary things from this branch.
Can you delete /build-logic, /plugin, all the unused dir, from this branch to simplify it?
engine/src/main/java/org/gradle/rbt/engine/ResourceBasedTestEngine.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/gradle/rbt/engine/ResourceBasedTestEngine.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/gradle/rbt/engine/ResourceBasedSelectorResolver.java
Show resolved
Hide resolved
donat
force-pushed
the
donat/demo-milestone-7
branch
from
94f096b to
c7f7d48
Compare
donat
commented
Nov 20, 2025
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <tests> | |||
| <test name="failingTest" /> | |||
Member
Author
There was a problem hiding this comment.
I introduced customTest so that the demo exhibits failing behavior, while the test task can succeed (the corresponding test definition does not contain <test name="failingTest" />)
Member
Author
|
@tresat ptal |
tresat
approved these changes
Nov 20, 2025
Member
tresat
left a comment
tresat
left a comment
There was a problem hiding this comment.
All the changes look good! Just 2 small things:
- Could you please add instructions about running the
customTestsuite to theREADMEso that we can be sure it's noticed. - Could you add a note that this is running against a snapshot branch to the
READMEas well, so we advertise that? IDK if we'll have time to build a 9.4.0-m2 and update this demo or if we'll just submit as it.
donat
force-pushed
the
donat/demo-milestone-7
branch
from
8a55214 to
7c542be
Compare
Member
Author
|
@tresat I've updated README |
tresat
approved these changes
Nov 21, 2025
donat
force-pushed
the
donat/demo-milestone-7
branch
2 times, most recently
from
2602b0a to
5a62cee
Compare
donat
force-pushed
the
donat/demo-milestone-7
branch
from
5a62cee to
5220e5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.