Fix bug in TestsReader #450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Optional.ofNullable to avoid throwing an NPE when a class file can't be read. Signed-off-by: Patrick Strawderman <[email protected]>
kilink
force-pushed
the
tests-reader-fix
branch
from
4eceb00 to
99f1997
Compare
snoopcheri
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Optional.ofNullableto avoid throwing an NPE when a class file can't be read.visitClassFileis annotated with@Nullable, and reading the code I can see that it returns null if it's unable to parse the class file. We ran into this issue when running tests on JDK 25. I guess it's indicative that Java 25 class files can't be parsed, but the intent of the code is to log a warning and proceed as far as I can tell.