-
Notifications
You must be signed in to change notification settings - Fork 156
test: integration test drift and sync #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
===========================================
- Coverage 64.74% 48.96% -15.78%
===========================================
Files 36 37 +1
Lines 3506 3590 +84
===========================================
- Hits 2270 1758 -512
- Misses 1085 1683 +598
+ Partials 151 149 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ed21141 to
3e138be
Compare
ceea7d2 to
1538dd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I think we made all the fixes work, I just don't know what's up with the code coverage for that one test, seems to fail consistently... |
|
@grcevski unbelievably, it seems a trailing YAML separator was to blame! See aabf5f0. Coverage works fine, the problem was:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing
OBI integration tests cannot yet be imported as they are unexported.
A workaround for now is to add a new script
scripts/check-obi-drift.shwhich can check for drift in integration tests between Beyla and OBI, and print the diff. If no drift is detected, the following can be seen:If run with
--sync, the same script will apply the changes to Beyla. Only integration test functions are synced, additional changes and copying may be required.--syncand additional changes were made to bring Beyla into sync with OBI