Skip to content

Conversation

@skl
Copy link
Member

@skl skl commented Oct 10, 2025

OBI integration tests cannot yet be imported as they are unexported.

A workaround for now is to add a new script scripts/check-obi-drift.sh which can check for drift in integration tests between Beyla and OBI, and print the diff. If no drift is detected, the following can be seen:

./scripts/check-obi-drift.sh
Checking for drift between Beyla and OBI test functions...

Summary: 0/85 test functions have drifted from OBI

If run with --sync, the same script will apply the changes to Beyla. Only integration test functions are synced, additional changes and copying may be required.

  1. 8cea08b The new script and go program used for function replacement
  2. 8861366 The script was run with --sync and additional changes were made to bring Beyla into sync with OBI

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 0% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.96%. Comparing base (71fe928) to head (0b4c4d4).

Files with missing lines Patch % Lines
scripts/replace-function.go 0.00% 84 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2241       +/-   ##
===========================================
- Coverage   64.74%   48.96%   -15.78%     
===========================================
  Files          36       37        +1     
  Lines        3506     3590       +84     
===========================================
- Hits         2270     1758      -512     
- Misses       1085     1683      +598     
+ Partials      151      149        -2     
Flag Coverage Δ
integration-test 15.90% <ø> (-36.69%) ⬇️
k8s-integration-test 2.93% <ø> (-63.86%) ⬇️
oats-test 0.00% <ø> (-16.02%) ⬇️
unittests 42.20% <0.00%> (-1.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skl skl force-pushed the skl/sync-integration-tests branch from ed21141 to 3e138be Compare October 20, 2025 15:40
@skl skl force-pushed the skl/sync-integration-tests branch from ceea7d2 to 1538dd4 Compare October 20, 2025 16:30
@grcevski grcevski marked this pull request as ready for review October 20, 2025 22:35
@grcevski grcevski requested a review from a team as a code owner October 20, 2025 22:35
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski
Copy link
Contributor

I think we made all the fixes work, I just don't know what's up with the code coverage for that one test, seems to fail consistently...

@skl
Copy link
Member Author

skl commented Oct 21, 2025

@grcevski unbelievably, it seems a trailing YAML separator was to blame! See aabf5f0. Coverage works fine, the problem was:

  1. the coverage merge command failed because:
  2. no coverage was generated, because:
  3. no tests were executed, because:
  4. kind cluster setup failed due to a duplicate manifest deployment, because:
  5. the trailing YAML separator causes some kind of duplicate read/write by the YAML decoder! 🙃

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@skl skl merged commit 7a5e80d into main Oct 21, 2025
49 checks passed
@skl skl deleted the skl/sync-integration-tests branch October 21, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants