-
Notifications
You must be signed in to change notification settings - Fork 65
Handle case where the frontend url already contains query parameters #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Handle case where the frontend url already contains query parameters #366
Conversation
|
How about using urllib? https://stackoverflow.com/a/64117554/6999563 |
Not necessarily because the frontend url might be a relative URL (ie "/login" and not "http://my-domain.com/login") which won't parse under urlparse |
Coverage dropped. It would be nice to add a test.
@PythonCoderAS It would be nice if you could add a test as well. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Bump |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Hi, this is still an active PR with a test case, could this please be reviewed? |
To my knowledge, if there is a "?" in the URL, everything after is a query parameter, so we check for a "?" and if one does exist we use "&" instead of "?".
Fix #365