Skip to content

fix: set BackoffLimit to zero for starter and stopper jobs to prevent excessive pod creation #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: set BackoffLimit to zero for starter and stopper jobs to prevent excessive pod creation #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fcc2d3
fix: set BackoffLimit to zero for starter job to prevent excessive po…
moko-poi Sep 29, 2025
ef6a9bb
test: set BackoffLimit to 0 for starter and stopper job tests
moko-poi Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/resources/jobs/starter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ func NewStarterJob(k6 *v1alpha1.TestRun, hostname []string) *batchv1.Job {
resourceRequirements = k6.GetSpec().Starter.Resources
}

var zero32 int32

return &batchv1.Job{
ObjectMeta: metav1.ObjectMeta{
Name: fmt.Sprintf("%s-starter", k6.NamespacedName().Name),
Expand All @@ -70,6 +72,7 @@ func NewStarterJob(k6 *v1alpha1.TestRun, hostname []string) *batchv1.Job {
Annotations: starterAnnotations,
},
Spec: batchv1.JobSpec{
BackoffLimit: &zero32,
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: starterLabels,
Expand Down
4 changes: 4 additions & 0 deletions pkg/resources/jobs/starter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
func TestNewStarterJob(t *testing.T) {

automountServiceAccountToken := true
zero := int32(0)

expectedOutcome := &batchv1.Job{
ObjectMeta: metav1.ObjectMeta{
Expand All @@ -30,6 +31,7 @@ func TestNewStarterJob(t *testing.T) {
},
},
Spec: batchv1.JobSpec{
BackoffLimit: &zero,
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: map[string]string{
Expand Down Expand Up @@ -106,6 +108,7 @@ func TestNewStarterJob(t *testing.T) {
func TestNewStarterJobIstio(t *testing.T) {

automountServiceAccountToken := true
zero := int32(0)

expectedOutcome := &batchv1.Job{
ObjectMeta: metav1.ObjectMeta{
Expand All @@ -121,6 +124,7 @@ func TestNewStarterJobIstio(t *testing.T) {
},
},
Spec: batchv1.JobSpec{
BackoffLimit: &zero,
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: map[string]string{
Expand Down
4 changes: 4 additions & 0 deletions pkg/resources/jobs/stopper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (

func TestNewStopperJob(t *testing.T) {
automountServiceAccountToken := true
zero := int32(0)

expectedOutcome := &batchv1.Job{
ObjectMeta: metav1.ObjectMeta{
Expand All @@ -28,6 +29,7 @@ func TestNewStopperJob(t *testing.T) {
},
},
Spec: batchv1.JobSpec{
BackoffLimit: &zero,
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: map[string]string{
Expand Down Expand Up @@ -93,6 +95,7 @@ func TestNewStopperJob(t *testing.T) {

func TestNewStopJobIstio(t *testing.T) {
automountServiceAccountToken := true
zero := int32(0)

expectedOutcome := &batchv1.Job{
ObjectMeta: metav1.ObjectMeta{
Expand All @@ -108,6 +111,7 @@ func TestNewStopJobIstio(t *testing.T) {
},
},
Spec: batchv1.JobSpec{
BackoffLimit: &zero,
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: map[string]string{
Expand Down