Fix web-dashboard output conflict #4826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
requested review from
codebien and
joanlopez
and removed request for
a team
joanlopez
previously approved these changes
Jun 9, 2025
codebien
added
the
breaking change
codebien
requested changes
Jun 9, 2025
Contributor
There was a problem hiding this comment.
@inancgumus can you add a unit test for it, please?
As we stop supporting a use case, we should probably add a warning in the case a duplicate is intercepted.
I've marked as breaking change for now, but we will discuss internally if this is really the case or not as we never documented it before.
inancgumus
force-pushed
the
fix/4707-web-dashboard-output-conflict
branch
4 times, most recently
from
5e9470e to
00d10b0
Compare
Running: K6_WEB_DASHBOARD=true k6 run --out web-dashboard script.js Results: listen tcp :port: bind: address already in use
inancgumus
force-pushed
the
fix/4707-web-dashboard-output-conflict
branch
from
00d10b0 to
42da59e
Compare
codebien
removed
the
breaking change
codebien
approved these changes
Jun 9, 2025
Contributor
codebien
left a comment
codebien
left a comment
There was a problem hiding this comment.
LGTM, we decided to not mark as a breaking change as this was an undefined case.
Contributor
Author
|
Superseeded by #4913. |
Contributor
|
@inancgumus the linked pull request seems wrong. Are you sure of the link? |
Contributor
Author
|
@codebien fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix web-dashboard output conflict.
Why?
Running:
Results:
Also see #4707.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Closes #4707