-
Notifications
You must be signed in to change notification settings - Fork 1.5k
remove enable community extensions flag #5167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
remove enable community extensions flag #5167
Conversation
Signed-off-by: Pablo Chacin <[email protected]>
…y-extensions-flag
|
@pablochacin Is it really a breaking change? In the end the behavior is not changing. If this is really a breaking change then we have to work-around it because it isn't allowed in v1.x, or we have to wait for v2.x. |
|
@codebien I think it is a breaking change in the sense that users can't opt out of community extensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pablochacin I now agree with you, this is a breaking change and it isn't allowed so we have to discuss how to make it backward compatible, or wait for v2.
What?
Removes the enable community extensions flag and the need to adjust the build service's URL to select the
osscatalog when they were enabled.Why?
After alll extensions were integrated into a single catalog that includes both official and community extensions, and all these extensions are supported in GCK6, there's no need to explicitly enable community extensions.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Closes https://github.com/grafana/k6-cloud/issues/3747