feat(goldfish): Add support for query results in object storage #19410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ADD COLUMN cell_a_result_uri TEXT NULL AFTER cell_a_status_code, | ||
| ADD COLUMN cell_b_result_uri TEXT NULL AFTER cell_a_result_uri, | ||
| ADD COLUMN cell_a_result_size_bytes BIGINT NULL AFTER cell_b_result_uri, | ||
| ADD COLUMN cell_b_result_size_bytes BIGINT NULL AFTER cell_a_result_size_bytes, |
There was a problem hiding this comment.
will result_size_bytes be different from the response_size we already have?
Signed-off-by: Jordan Rushing <[email protected]>
JordanRushing
force-pushed
the
loki-goldfish-results-storage
branch
from
8564bdc to
5704db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for storing query results from Goldfish comparisons directly in object storage for deep diffing to understand hash mismatches in certain scenarios.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR