Skip to content

Conversation

@chaudum
Copy link
Contributor

@chaudum chaudum commented Oct 13, 2025

Summary

The v1 engine has a mechanism to rename labels in case they have the same name but different origin, such as labels, structured metadata, or parsed fields.

  1. In case a log line has a structured metadata key with the same name as the label name of the stream, than the metadata key is suffixed with _extracted, such as service_extracted, if service exists in both labels and metadata.
  2. In case a parser creates a parsed field with the same as the label name of the stream, then the parsed key is suffixed with _extracted in the same way as case 1. However, if the field name also collides with a structured metadata key, then the extracted structured metadata is replaced with the extracted parsed field.

This PR only implements the second case.

This PR is a follow up on #19470

Copy link
Contributor

@ivkalita ivkalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major comments from me, thank you!

@chaudum chaudum force-pushed the chaudum/parsed-extracted branch from eeddc56 to 0e7e117 Compare October 14, 2025 08:33
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chaudum and others added 7 commits October 14, 2025 12:04
After parsing log lines, field names need to be checked whether they
collide with label field names.

Follow up on #19470
Co-authored-by: Ivan Kalita <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
Co-authored-by: Ivan Kalita <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
@chaudum chaudum force-pushed the chaudum/parsed-extracted branch from a7bcb80 to 06df9a8 Compare October 14, 2025 10:04
@chaudum chaudum enabled auto-merge (squash) October 14, 2025 10:04
@chaudum chaudum merged commit 3c5f759 into main Oct 14, 2025
63 checks passed
@chaudum chaudum deleted the chaudum/parsed-extracted branch October 14, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants