Skip to content

feat: add validation for k6 extensions and version pragmas #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2025
Merged

feat: add validation for k6 extensions and version pragmas #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a9c148
feat: add validation for k6 extensions and version pragmas
VikaCep Sep 1, 2025
663de22
feat: add custom validation to monaco (#1259)
ckbedwell Sep 5, 2025
cede15b
fix: address review comments
VikaCep Sep 19, 2025
bcf519d
fix: refactor monaco validation to use acorn
VikaCep Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/components/CodeEditor/CodeEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { CodeEditorProps, ConstrainedEditorProps } from './CodeEditor.types';
import k6Types from './k6.types';

import { initializeConstrainedInstance, updateConstrainedEditorRanges } from './CodeEditor.utils';
import { wireCustomValidation } from './monacoValidation';

const addK6Types = (monaco: typeof monacoType) => {
Object.entries(k6Types).map(([name, type]) => {
Expand Down Expand Up @@ -116,6 +117,9 @@ export const CodeEditor = forwardRef(function CodeEditor(
handleValidation(monaco, editor);
});

// Wire custom red-squiggle markers for forbidden syntax
const disposeCustomValidation = wireCustomValidation(monaco, editor);

if (constrainedRanges) {
const instance = initializeConstrainedInstance(monaco, editor);
const model = editor.getModel();
Expand All @@ -126,6 +130,13 @@ export const CodeEditor = forwardRef(function CodeEditor(
updateConstrainedEditorRanges(instance, model, value, constrainedRanges, onDidChangeContentInEditableRange);
setConstrainedInstance(instance);
}

// Cleanup subscriptions on dispose
editor.onDidDispose(() => {
if (typeof disposeCustomValidation === 'function') {
disposeCustomValidation();
}
});
};

useEffect(() => {
Expand Down
Loading