SIMD #2294
Draft
SIMD #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
reviewed
Jun 15, 2025
| "build": [ | ||
| "dune build @native --no-buffer" | ||
| ], | ||
| "build": ["dune build @native --no-buffer"], |
There was a problem hiding this comment.
Why did the formatting change here?
| from "runtime/unsafe/wasmv128" include WasmV128 | ||
| use WasmV128.* | ||
|
|
||
| let (==) = (x, y) => { |
There was a problem hiding this comment.
Why not provide this in the runtime module?
There was a problem hiding this comment.
compiler/test/runtime might be a better place for this. I know the other unsafe tests exist here but we should honestly move those too. Especially as we would like to eventually split the runtime and stdlib.
| | WasmSimdConstI8x16 => | ||
| prim_type( | ||
| [ | ||
| ("lane0", Builtin_types.type_wasmi32), |
There was a problem hiding this comment.
I wonder if it would have been worth using a helper like List.init((index) => ("lane" ++ toString(index),Builtin_types.type_wasmi32), 15) for all of these.
| }; | ||
| let features = | ||
| if (Config.simd^) { | ||
| [Module.Feature.simd128, ...features]; |
There was a problem hiding this comment.
Binaryen's default behaviour is to error if a feature isn't enabled but the code is used right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.