chore(tests): Enable fs.test.gr
#2338
Draft
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr tires to enable our `fs.test.gr` suite to test the fs module in the stdlib. Some notes: * Tests will fail on this due to an upstream [uvwasi issue](nodejs/node#47193) that isn't patched until node `v24` * It's still unclear to me why removing a directory is returning `OperationNotPermitted` instead of `IsADirectory` like it should be. * I don't love how this test suite is written, it would be nice if we wrote all temporary files to a `tempTestDir` and only read from the `testDir` to make cleanup easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr tires to enable our
fs.test.grsuite to test the fs module in the stdlib.Some notes:
v24OperationNotPermittedinstead ofIsADirectorylike it should be.tempTestDirand only read from thetestDirto make cleanup easier.This is a draft due to the notes above.
Closes: #2320